Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts benchbin's args to have the same names as prover's args #2724

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Adjusts benchbin's args to have the same names as prover's args #2724

merged 2 commits into from
Nov 7, 2024

Conversation

diegoximenes
Copy link
Contributor

Adjusts benchbin's args to have the same names as prover's args.

Before:

./arbitrator/target/debug/benchbin --preimages-path ~/.arbitrum/validation-inputs/TestProgramStorage/20241003_112425/block_inputs_5.json --machine-path ./target/machines/latest/machine.wavm.br

After:

./arbitrator/target/debug/benchbin --json-inputs ~/.arbitrum/validation-inputs/TestProgramStorage/20241003_112425/block_inputs_5.json --binary ./target/machines/latest/machine.wavm.br

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Oct 7, 2024
eljobe
eljobe approved these changes Oct 11, 2024
View reviewed changes
arbitrator/bench/src/bin.rs Show resolved Hide resolved
@PlasmaPower PlasmaPower merged commit b8cf6ea into master Nov 7, 2024
15 checks passed
@PlasmaPower PlasmaPower deleted the adjust_benchbin_args branch November 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegoximenes @eljobe @PlasmaPower